[cmd/telemetrygen] Add Support for specifying Log Severity #30990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
reviewed
Feb 1, 2024
mx-psi
requested changes
Feb 2, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Frapschen
force-pushed
the
_Add_Support_for_specifying_Log_Severity
branch
from
73ee303 to
9fbb318
Compare
mx-psi
reviewed
Mar 19, 2024
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
mx-psi
reviewed
Mar 26, 2024
| @@ -82,3 +86,42 @@ func Run(c *Config, exp exporter, logger *zap.Logger) error { | |||
| wg.Wait() | |||
| return nil | |||
| } | |||
|
|
|||
| func parseSeverity(severityText string, severityNumber int32) (string, plog.SeverityNumber) { | |||
There was a problem hiding this comment.
Instead of using the default when invalid data is present, we should return an error.
For example, if severityNumber is outside of the valid range, we should return an error that says that the valid range is [1,24].
We may need to take care of the default case separately, but otherwise we shouldn't ignore what the user set, we should instead tell them that it is invalid.
…Severity' into _Add_Support_for_specifying_Log_Severity
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
mx-psi
reviewed
Apr 2, 2024
mx-psi
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #26498