[chore][receiver/hostmetrics, exporter/awsxray] Fix some more empty IDs #30994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braydonk
approved these changes
Feb 1, 2024
evan-bradley
approved these changes
Feb 1, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
…Ds (open-telemetry#30994) **Description:** - Makes the test on awsxray exporter use the `exportertest.NewNopCreateSettings().ID`. This is because this is the ID passed to `newTracesExporter`: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/2f5b0bc52cd160886b4e1ee03461704d6c440a8d/exporter/awsxrayexporter/awsxray_test.go#L109 Currently, this makes no difference, but it will once the ID on NewNopCreateSettings is fixed. - Also fixes the hostmetrics receiver ID, just for fun :) **Link to tracking Issue:** Needed for open-telemetry/opentelemetry-collector/pull/9414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
exportertest.NewNopCreateSettings().ID. This is because this is the ID passed tonewTracesExporter:opentelemetry-collector-contrib/exporter/awsxrayexporter/awsxray_test.go
Line 109 in 2f5b0bc
Link to tracking Issue: Needed for open-telemetry/opentelemetry-collector/pull/9414