Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][receiver/sqlquery] Remove redundant validate function #31042

Merged
merged 1 commit into from
Feb 5, 2024
Merged

[chore][receiver/sqlquery] Remove redundant validate function #31042

merged 1 commit into from
Feb 5, 2024

Conversation

crobert-1
Copy link
Member

Description:

Requested change by Dmitrii, this function was redundant as the underlying config has a Validate function called automatically.

@crobert-1 crobert-1 requested a review from dmitryax as a code owner February 5, 2024 19:24
@crobert-1 crobert-1 requested a review from a team February 5, 2024 19:24
@github-actions github-actions bot added the receiver/sqlquery SQL query receiver label Feb 5, 2024
@github-actions github-actions bot requested a review from pmcollins February 5, 2024 19:25
@dmitryax dmitryax merged commit 16a8655 into open-telemetry:main Feb 5, 2024
143 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@pmcollins pmcollins Awaiting requested review from pmcollins

Assignees

@Aneurysm9 Aneurysm9

Labels
receiver/sqlquery SQL query receiver
Projects
None yet
Milestone
v0.94.0
Development

Successfully merging this pull request may close these issues.
3 participants
@crobert-1 @dmitryax @Aneurysm9