[exporter/signalfx] Use "unknown" env correlation value as fallback #31052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
sfx-add-uknown-env
branch
2 times, most recently
from
7ef5e22 to
3ade5bf
Compare
Use the same fallback value for the metrics/tracing environment correlation calls as being set by the backend on the traces. This fixed the APM/IM correlation in the Splunk Observability UI for the users that send traces with no "deployment.environment" resource attribute value set.
dmitryax
force-pushed
the
sfx-add-uknown-env
branch
from
3ade5bf to
43d56e8
Compare
atoulme
approved these changes
Feb 5, 2024
crobert-1
approved these changes
Feb 5, 2024
pjanotti
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Use the same fallback value for the metrics/tracing environment correlation calls as being set by the backend on the traces. This fixed the APM/IM correlation in the Splunk Observability UI for the users that send traces with no "deployment.environment" resource attribute value set.
Testing: Updated unit test and validated the fix manually.