Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][pkg/stanza] Fix goroutine leak in regex parser #31108

Merged
merged 2 commits into from
Feb 8, 2024
Merged

[chore][pkg/stanza] Fix goroutine leak in regex parser #31108

merged 2 commits into from
Feb 8, 2024

Conversation

djaglowski
Copy link
Member

Fixes #31093

@djaglowski djaglowski marked this pull request as ready for review February 7, 2024 15:19
@djaglowski djaglowski requested review from a team and dmitryax February 7, 2024 15:19
mx-psi
mx-psi approved these changes Feb 7, 2024
View reviewed changes
pkg/stanza/operator/parser/regex/cache.go Outdated Show resolved Hide resolved
crobert-1
crobert-1 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@crobert-1 crobert-1 mentioned this pull request Feb 7, 2024
Open
@djaglowski djaglowski merged commit 82cbc43 into open-telemetry:main Feb 8, 2024
156 checks passed
@djaglowski djaglowski deleted the pkg-stanza-regex-leak branch February 8, 2024 14:55
@github-actions github-actions bot added this to the next release milestone Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobert-1 crobert-1 crobert-1 approved these changes

@mx-psi mx-psi mx-psi approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax

Assignees

@mx-psi mx-psi

Labels
pkg/stanza
Projects
None yet
Milestone
v0.95.0
Development

Successfully merging this pull request may close these issues.

[pkg/stanza/operator/parser/regex] Leaking goroutine when cache size is set to non-zero
3 participants
@djaglowski @mx-psi @crobert-1