handling http semantic convention breaking changes in v1.23.0 #31120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxiamxia
reviewed
Feb 8, 2024
mxiamxia
reviewed
Feb 8, 2024
thpierce
reviewed
Feb 8, 2024
thpierce
reviewed
Feb 13, 2024
mxiamxia
approved these changes
Feb 20, 2024
|
@bogdandrutu @atoulme Would you help us review and merge this PR? |
|
@open-telemetry/collector-contrib-approvers Would you help us review and merge this PR? |
|
Please address lint issues |
@TylerHelmuth addressed! Please take a look. |
|
@open-telemetry/collector-contrib-approvers Would you help us review and merge this PR? |
bryan-aguilar
approved these changes
Feb 27, 2024
bryan-aguilar
added
the
ready to merge
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…elemetry#31120) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> `awsxrayexporter` is able to handle both old and new versions of http span attributes, support translate new http attributes to xray segment fields by following http [server span](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md#http-server) and [client span](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md#http-client) spec. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#30935 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> https://opentelemetry.io/blog/2023/http-conventions-declared-stable/ --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
awsxrayexporteris able to handle both old and new versions of http span attributes, support translate new http attributes to xray segment fields by following http server span and client span spec.Link to tracking Issue:
#30935
Testing:
Documentation:
https://opentelemetry.io/blog/2023/http-conventions-declared-stable/