-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] [exporter/sumologic] sync internal package with Sumo Logic repository #31480
[chore] [exporter/sumologic] sync internal package with Sumo Logic repository #31480
Conversation
…tory Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
ada8971
to
0c3ecb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really a "feature" as the commit message suggests? Looks more like a refactoring/chore.
Does adding these files change anything in the bahavior of the exporter?
It adds metrics to the collector, but not now. This PR is purely to reduce size of final PR. I would add |
If it doesn't change the behavior of the exporter, then it's definitely not a |
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
17452b7
to
90891ad
Compare
cc: @open-telemetry/collector-contrib-maintainer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the conflicts
6be9931
to
4c025f2
Compare
Description:
Those files can be added independently of their usage which should make other PRs smaller
Link to tracking Issue: #31479
Testing:
Unit tests
Documentation: N/A