Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/awss3receiver] Introduce the AWS S3 Receiver #31710

Merged
merged 17 commits into from
Mar 25, 2024
Merged

[receiver/awss3receiver] Introduce the AWS S3 Receiver #31710

merged 17 commits into from
Mar 25, 2024

Conversation

adcharre
Copy link
Contributor

Description: Initial skeleton implementation of the AWS S3 receiver described in issue #30750.
Full implementation will follow in future PRs.

Link to tracking Issue: #30750

Testing: -

Documentation: Initial README added.

@adcharre adcharre requested review from a team and mx-psi March 12, 2024 14:25
@github-actions github-actions bot added the cmd/otelcontribcol otelcontribcol command label Mar 12, 2024
@mx-psi mx-psi requested a review from atoulme March 12, 2024 14:56
crobert-1
crobert-1 reviewed Mar 12, 2024
View reviewed changes
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this change includes tests, can you add goleak tests as well? It's a recently added requirement for writing new components 👍

There's an entry now in the docs here.

receiver/awss3receiver/README.md Show resolved Hide resolved
@atoulme atoulme added the Accepted Component New component has been sponsored label Mar 12, 2024
@mx-psi mx-psi requested a review from crobert-1 March 14, 2024 10:59
crobert-1
crobert-1 reviewed Mar 14, 2024
View reviewed changes
receiver/awss3receiver/README.md Outdated Show resolved Hide resolved
receiver/awss3receiver/metadata.yaml Outdated Show resolved Hide resolved
receiver/awss3receiver/metadata.yaml Outdated Show resolved Hide resolved
@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label Mar 20, 2024
@adcharre
Copy link
Contributor Author

@crobert-1 / @mx-psi - Anything left for me to do here before this PR can be merged?

@crobert-1
Copy link
Member

@crobert-1 / @mx-psi - Anything left for me to do here before this PR can be merged?

Nothing that I'm aware of. Since the ready to merge label is added, it's just waiting for a maintainer to merge.

(I didn't get a chance to look through thoroughly enough to approve, but I don't have any notable concerns here.)

@dmitryax dmitryax merged commit 011256c into open-telemetry:main Mar 25, 2024
147 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 25, 2024
@dmitryax dmitryax mentioned this pull request Mar 25, 2024
Merged
dmitryax added a commit that referenced this pull request Mar 26, 2024
@dmitryax
[chore] Update dependencies to fix the build (#31942)
927b021 
Follow-up to merge
#31710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobert-1 crobert-1 crobert-1 left review comments

@atoulme atoulme atoulme approved these changes

@mx-psi mx-psi Awaiting requested review from mx-psi

Assignees

@mx-psi mx-psi

Labels
Accepted Component New component has been sponsored cmd/otelcontribcol otelcontribcol command ready to merge Code review completed; ready to merge by maintainers reports/distributions/contrib.yaml
Projects
None yet
Milestone
v0.97.0
Development

Successfully merging this pull request may close these issues.
5 participants
@adcharre @crobert-1 @atoulme @mx-psi @dmitryax