Change the way that X-Ray exporter annotation converter work #31732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added, thanks |
songy23
approved these changes
Mar 14, 2024
|
@songy23 Hi Yang, thanks for you time :) Can you please help me to trigger the test run again? I found some lint issue and fixed :( |
mxiamxia
approved these changes
Mar 20, 2024
srprash
approved these changes
Mar 20, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@atoulme @songy23 Hi Team, I taken a look at the test result and I believe it's fine. The only issue on the test is not related to my code (it's seems not even a issue, just an accidental terminate on the run). If you think the test is enough, can you help us merge the code? If not, can you try to rerun the test again? Thanks |
songy23
added
ready to merge
andrzej-stencel
merged commit 77cf7f3
into
open-telemetry:main
150 of 151 checks passed
andrzej-stencel
pushed a commit
that referenced
this pull request
May 15, 2024
**Description:** Moving xray exporter allow-dot feature gate from alpha to beta stage It's a follow up change for #31732 **Testing:** Unit test **Documentation:** https://github.com/XinRanZhAWS/opentelemetry-collector-contrib/blob/f0863f481445e7205e3096a9a536463e3a51de81/.chloggen/xray_exporter_allow_dot_annotation.yaml Purpose of this feature gate: In the past, X-Ray doesn’t support “.”. So we have a translator in x-ray export to translates it to “_” before sending traces to X-Ray Service. To match otel naming style, x-ray service team decide to change their service to support both "." type and "" type of naming. In this case the translator that translate "." to "" is no-longer needed. This PR change the way this translator work X-Ray PMs agree on rolling out this change by using feature-gate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In the past, X-Ray doesn’t support “.”. So we have a translator in x-ray export to translates it to “_” before sending traces to X-Ray Service.
To match otel naming style, x-ray service team decide to change their service to support both "." type and "" type of naming. In this case the translator that translate "." to "" is no-longer needed. This PR change the way this translator work
X-Ray PMs agree on rolling out this change by using feature-gate
Testing:
Unit test