-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/splunkhecreceiver] use ACK extension in HEC receiver #31767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please add a changelog, and enter info in the PR title. |
atoulme
reviewed
Mar 15, 2024
atoulme
reviewed
Mar 15, 2024
zpzhuSplunk
force-pushed
the
hec_receiver_ack
branch
from
March 18, 2024 02:20
a399f50
to
1a8f056
Compare
github-actions
bot
added
cmd/configschema
configschema command
cmd/otelcontribcol
otelcontribcol command
cmd/oteltestbedcol
internal/splunk
testbed
labels
Mar 18, 2024
zpzhuSplunk
force-pushed
the
hec_receiver_ack
branch
from
March 18, 2024 05:41
1a8f056
to
c6d90cc
Compare
zpzhuSplunk
changed the title
[WIP] [receiver/splunkhecreceiver] use ACK extension in HEC receiver
[receiver/splunkhecreceiver] use ACK extension in HEC receiver
Mar 20, 2024
zpzhuSplunk
force-pushed
the
hec_receiver_ack
branch
2 times, most recently
from
March 21, 2024 21:04
4cd2c1b
to
ecb8586
Compare
zpzhuSplunk
force-pushed
the
hec_receiver_ack
branch
from
March 21, 2024 21:14
273a0c0
to
2a84069
Compare
zpzhuSplunk
force-pushed
the
hec_receiver_ack
branch
from
March 22, 2024 23:26
ff273df
to
f8de4f9
Compare
zpzhuSplunk
force-pushed
the
hec_receiver_ack
branch
from
March 25, 2024 06:20
a5d09ca
to
213b3eb
Compare
atoulme
reviewed
Apr 16, 2024
atoulme
reviewed
Apr 16, 2024
atoulme
reviewed
Apr 16, 2024
atoulme
reviewed
Apr 16, 2024
atoulme
reviewed
Apr 16, 2024
dmitryax
reviewed
Apr 16, 2024
atoulme
reviewed
Apr 17, 2024
crobert-1
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just some wording nits.
Co-authored-by: Curtis Robert <crobert@splunk.com>
Co-authored-by: Curtis Robert <crobert@splunk.com>
Co-authored-by: Curtis Robert <crobert@splunk.com>
dmitryax
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cmd/configschema
configschema command
cmd/otelcontribcol
otelcontribcol command
cmd/oteltestbedcol
exporter/elasticsearch
exporter/splunkhec
internal/splunk
receiver/splunkhec
testbed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding support for ack extension in the splunkhecreceiver. The receiver can now be configured to using different ack extensions to ack events.
Link to tracking Issue:
#26376
Testing:
Documentation: