Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/splunkhecreceiver] use ACK extension in HEC receiver #31767

Merged
merged 74 commits into from
Apr 18, 2024

Conversation

zpzhuSplunk
Copy link
Contributor

@zpzhuSplunk zpzhuSplunk commented Mar 14, 2024

Description:

Adding support for ack extension in the splunkhecreceiver. The receiver can now be configured to using different ack extensions to ack events.
Link to tracking Issue:
#26376
Testing:

Documentation:

@atoulme
Copy link
Contributor

atoulme commented Mar 15, 2024

Please add a changelog, and enter info in the PR title.

@zpzhuSplunk zpzhuSplunk changed the title [WIP] [receiver/splunkhecreceiver] use ACK extension in HEC receiver [receiver/splunkhecreceiver] use ACK extension in HEC receiver Mar 20, 2024
@zpzhuSplunk zpzhuSplunk force-pushed the hec_receiver_ack branch 2 times, most recently from 4cd2c1b to ecb8586 Compare March 21, 2024 21:04
internal/splunk/common.go Outdated Show resolved Hide resolved
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just some wording nits.

receiver/splunkhecreceiver/README.md Outdated Show resolved Hide resolved
receiver/splunkhecreceiver/README.md Outdated Show resolved Hide resolved
receiver/splunkhecreceiver/README.md Outdated Show resolved Hide resolved
zpzhuSplunk and others added 3 commits April 18, 2024 15:55
Co-authored-by: Curtis Robert <crobert@splunk.com>
Co-authored-by: Curtis Robert <crobert@splunk.com>
Co-authored-by: Curtis Robert <crobert@splunk.com>
@dmitryax dmitryax merged commit fcebe4d into open-telemetry:main Apr 18, 2024
156 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants