[pkg/stanze, receiver/filelog] Allow opting into scope name and version #31771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
commented
Mar 14, 2024
Comment on lines
+84
to
+86
| func withPackageName(name string) converterOption { | ||
| return packageNameOption{name} | ||
| } |
There was a problem hiding this comment.
The interface pattern allows this to be an opt-in solution, but feels kinda magical. I'm not sold on this idea, but it does provide the value without any breaking changes and I think we do need the component to provide the value since the ID is not the same as the package name.
djaglowski
requested changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the option for Stanza users to opt in to setting the scope name and version by implementing extra interfaces.
Link to tracking Issue:
Closes #31737