Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] lint fixes in cmd/telemetrygen & cmd/opampsupervisor #31932

Merged
merged 1 commit into from
Mar 25, 2024
Merged

[chore] lint fixes in cmd/telemetrygen & cmd/opampsupervisor #31932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cmd/opampsupervisor/supervisor/supervisor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,12 +368,12 @@ func (s *Supervisor) startOpAMP() error {
s.logger.Error("Server returned an error response", zap.String("message", err.ErrorMessage))
},
OnMessageFunc: s.onMessage,
OnOpampConnectionSettingsFunc: func(_ context.Context, settings *protobufs.OpAMPConnectionSettings) error {
OnOpampConnectionSettingsFunc: func(_ context.Context, _ *protobufs.OpAMPConnectionSettings) error {
// TODO: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/21043
s.logger.Debug("Received ConnectionSettings request")
return nil
},
OnOpampConnectionSettingsAcceptedFunc: func(_ context.Context, settings *protobufs.OpAMPConnectionSettings) {
OnOpampConnectionSettingsAcceptedFunc: func(_ context.Context, _ *protobufs.OpAMPConnectionSettings) {
// TODO: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/21043
s.logger.Debug("ConnectionSettings accepted")
},
Expand All @@ -385,7 +385,7 @@ func (s *Supervisor) startOpAMP() error {
}
return nil
},
SaveRemoteConfigStatusFunc: func(_ context.Context, status *protobufs.RemoteConfigStatus) {
SaveRemoteConfigStatusFunc: func(_ context.Context, _ *protobufs.RemoteConfigStatus) {
// TODO: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/21079
},
GetEffectiveConfigFunc: func(_ context.Context) (*protobufs.EffectiveConfig, error) {
Expand Down
6 changes: 3 additions & 3 deletions cmd/telemetrygen/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ var tracesCmd = &cobra.Command{
Use: "traces",
Short: fmt.Sprintf("Simulates a client generating traces. (Stability level: %s)", metadata.TracesStability),
Example: "telemetrygen traces",
RunE: func(cmd *cobra.Command, args []string) error {
RunE: func(_ *cobra.Command, _ []string) error {
return traces.Start(tracesCfg)
},
}
Expand All @@ -46,7 +46,7 @@ var metricsCmd = &cobra.Command{
Use: "metrics",
Short: fmt.Sprintf("Simulates a client generating metrics. (Stability level: %s)", metadata.MetricsStability),
Example: "telemetrygen metrics",
RunE: func(cmd *cobra.Command, args []string) error {
RunE: func(_ *cobra.Command, _ []string) error {
return metrics.Start(metricsCfg)
},
}
Expand All @@ -56,7 +56,7 @@ var logsCmd = &cobra.Command{
Use: "logs",
Short: fmt.Sprintf("Simulates a client generating logs. (Stability level: %s)", metadata.LogsStability),
Example: "telemetrygen logs",
RunE: func(cmd *cobra.Command, args []string) error {
RunE: func(_ *cobra.Command, _ []string) error {
return logs.Start(logsCfg)
},
}
Expand Down