Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] [exporter/clickhouse] add warnings to metadata #32130

Closed

Conversation

SpencerTorres
Copy link
Member

Description:
Resolves #32041

Also allows marking this exporter as completed on #19172

Declare in the metadata.yaml that this exporter has no warnings.
Because there are no warnings, there is no change to the README.md after running make generate

@SpencerTorres SpencerTorres requested a review from dmitryax as a code owner April 2, 2024 20:48
@SpencerTorres SpencerTorres requested a review from a team April 2, 2024 20:48
@github-actions github-actions bot requested review from Frapschen and hanjm April 2, 2024 20:48
@SpencerTorres SpencerTorres changed the title [exporter/clickhouse] add warnings to metadata [chore] [exporter/clickhouse] add warnings to metadata Apr 2, 2024
@atoulme
Copy link
Contributor

atoulme commented Apr 3, 2024

That's the default value, I'm not sure that needs to be explicit? Is there a practical advantage I am missing?

@SpencerTorres
Copy link
Member Author

That's the default value, I'm not sure that needs to be explicit? Is there a practical advantage I am missing?

The intent was to show that we have reviewed #19172 and explicitly say that we have no warnings.

If referencing #32041 is good enough to mark our component as complete then we can cancel this PR. I did see some other components provide an empty array. Kind of like null vs undefined in JavaScript, this PR makes it clear we have none-- or that we haven't forgotten to review it

@atoulme
Copy link
Contributor

atoulme commented Apr 4, 2024

OK. Maybe there's something else we need to do there to make it clear that warnings were reviewed, as this won't change README. I am filing open-telemetry/opentelemetry-collector#9894 to follow up.

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Apr 19, 2024
Copy link
Contributor

github-actions bot commented May 3, 2024

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[exporter/clickhouse] Component Warning Header Discussion
4 participants