-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmd/opampsupervisor] Fix restart delay when agent process exits unexpectedly #32150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this out, it resolves the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really excited to have this fixed, thanks.
I think the way we're handling channels is the best we can do, but looks a little funny. I just added a few suggestions to explain why we're doing what we are. If anyone else has ideas for more idiomatic ways to make these behave sensibly, I'm open to other suggestions.
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
@srikanthccv It looks like there's a linting error, could you look into it? |
Description:
Reset should called only on stopped or expired timers with drained channels. If the timer already expired (and the channel was not cleared) it reads from the timer's channel to clear it.
Link to tracking Issue: Fixes #27891
Testing:
Documentation: