Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][receiver/namedpipe] Enable goleak check #32200

Merged
merged 8 commits into from
Apr 16, 2024
Merged

[chore][receiver/namedpipe] Enable goleak check #32200

merged 8 commits into from
Apr 16, 2024

Commits on Apr 12, 2024

  1. [chore][receiver/namedpipe] Enable goleak check

    @crobert-1
    crobert-1 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    e1bac06 View commit details
    Browse the repository at this point in the history

  2. Remove shutdown call to avoid timeout

    @crobert-1
    crobert-1 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    1ee606d View commit details
    Browse the repository at this point in the history

  3. Use context with cancel

    @crobert-1
    crobert-1 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    b79d14d View commit details
    Browse the repository at this point in the history

  4. Remove context changes in test

    @crobert-1
    crobert-1 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    41e0cc8 View commit details
    Browse the repository at this point in the history

  5. [test] Remove shutdown to see if test passes

    @crobert-1
    crobert-1 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    919ca87 View commit details
    Browse the repository at this point in the history

  6. [test] Check if stopping converter first allows shutdown to be succes… 

    …sful
    @crobert-1
    crobert-1 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    5f986d7 View commit details
    Browse the repository at this point in the history

  7. Call defer properly

    @crobert-1
    crobert-1 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    8afc7e7 View commit details
    Browse the repository at this point in the history

  8. Move converter stop back to original position

    @crobert-1
    crobert-1 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    c240464 View commit details
    Browse the repository at this point in the history