[receiver/awss3receiver] Initial implementation #32222
Conversation
| unmarshaler = &ptrace.JSONUnmarshaler{} | ||
| } | ||
| if strings.HasSuffix(key, ".binpb") { | ||
| unmarshaler = &ptrace.ProtoUnmarshaler{} |
There was a problem hiding this comment.
We can maybe do something here in a future PR where the unmarshaler is dictated by config. I appreciate how this works well when you don't know what data to expect though.
There was a problem hiding this comment.
Agreed - at this stage just want to get the basics in and then add the ability to use extensions to unmarshall data next.
@crobert-1 Thanks for the quick review! I'll take a look through those shortly. |
I think I've been through all your original comments and resolved them now. |
|
Ready to go! |
|
Hey @adcharre, sorry for the delay with merging. Can you please rebase again? |
|
Rebased again ... @dmitryax any chance this can go in soon while I just love resolving merge conflicts I would like to see this merged :-) |
|
@adcharre I tried to help but I don't think I got it right, mind taking a look? |
|
@dmitryax rebased ready for merging |
Description: This is the initial implementation of the AWS S3 receiver. The receiver can load trace from an S3 bucket starting at the configured time until the stop time. Json and protobuf formats are supported along with gzip compression.
Link to tracking Issue: #30750
Testing: Unit tests added and read real trace from an S3 bucket.
Documentation: None added