Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][CI/CD] Upgrade golang 1.22 version for unittest-matrix #32288

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

crobert-1
Copy link
Member

@crobert-1 crobert-1 commented Apr 9, 2024

Description:

Version 1.22.0 of golang only has a darwin OS build of arm architecture available from actions/setup-go and actions/go-versions, so hopefully upgrading to use 1.22.2 will help tests pass.

Link to tracking Issue:
Fixes #32286

Testing:
None yet, but hopefully from this CI/CD run of build-and-test/unittest-matrix we can confirm if the updated go version resolves this issue for arm testing.

Run shows 1.22.2 got picked up successfully:

Setup go version spec 1.22.2
...
Attempting to download 1.22.2...
...
matching 1.22.2...
Acquiring 1.22.2 from https://github.com/actions/go-versions/releases/download/1.22.2-8[54](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8622703577/job/23634936527?pr=32288#step:6:55)8848001/go-1.22.2-linux-arm64.tar.gz
...
Extracting Go...

@crobert-1
Copy link
Member Author

crobert-1 commented Apr 9, 2024

Looks like there are still failures intermittently, but much less impacting, and a different kind. The first failure was a unittest failure on an ARM run, the second was vmmeter failed to clean up properly. Since all tests still run, both of these are better in my mind than the current result of many tests being cancelled due to arm failures.

@crobert-1 crobert-1 marked this pull request as ready for review April 9, 2024 22:21
@crobert-1 crobert-1 requested review from a team and songy23 April 9, 2024 22:21
@codeboten codeboten merged commit 8fb6db0 into open-telemetry:main Apr 10, 2024
172 of 173 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[flaky test][arm builds] CI/CD failing during arm builds intermittently
4 participants