[testbed] Fix loadgenerator race condition #32351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just realized that I misread the code and the fix will not work 🤦 . Putting it in draft until I figure out the correct fix. |
|
@songy23 Thanks for the review. The previous fix was not totally correct so I have updated the fix to propagate the errors from |
crobert-1
reviewed
Apr 12, 2024
crobert-1
reviewed
Apr 12, 2024
ProviderSender based load generator had a race condition when used with Parallel option configured to a value greater than 1. The commit fixes the race condition by changing the behavior of how logging works w.r.t previously observed errors.
crobert-1
approved these changes
Apr 16, 2024
|
@songy23 @crobert-1 Is there anything blocking here to get this merged? |
songy23
approved these changes
Apr 18, 2024
songy23
added
the
ready to merge
|
@atoulme Friendly ping, will you be able to review this whenever you have time and merge the PR if things look okay? |
|
@atoulme Apologies for the 2nd ping but would it be possible to get this merged this week? (AFAICS the test failures is unrelated to this PR) |
codeboten
approved these changes
May 1, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes a race condition in testbed's default load generator (
ProviderSender). The fix changes the behavior of how logging works for theProviderSender. Before this PR, the code will try to log errors if the previous error is not the same and it would try to do this across goroutines. Now, each error will be logged if the previous error is not the same for each goroutine.Alternatively, we can also build a logger using bloom filter to try to log each error once though I am not sure if that would be required. This PR offers a quick fix while keeping the behavior reasonably close to the current behavior.
Closes #32326
Link to tracking Issue: #32326
Testing: Follow the steps in the tracking issue.
Documentation: Not required.