[receiver/awscontainerinsight] Fix memory leak on shutdown in k8s API server #32405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
fatsheep9146
approved these changes
May 10, 2024
|
nicely ping @Aneurysm9 for review |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
atoulme
approved these changes
Jun 19, 2024
|
@Aneurysm9 please review |
This was referenced Jun 19, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Pinging code owners @Aneurysm9 @pxaws |
This was referenced Sep 10, 2024
This was referenced Sep 24, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This was referenced Oct 8, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change has 4 main parts:
Shutdownas it has its own running goroutines that need shutdown to avoid leaking.Shutdownin the failure scenarios ofNew. This is required because once again, goroutines are started during the k8s API server'sNewcall stack. Since it returnsnilon error, there's no way to shutdown once it returns. This meansShutdownmust be called on error.goleakchecks to help ensure no goroutines are being leaked.Link to tracking Issue:
#30438
Testing:
All existing tests are passing, as well as added
goleakchecks.