-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore][receiver/awscontainerinsight] Enable goleak checks in internal packages #32406
[chore][receiver/awscontainerinsight] Enable goleak checks in internal packages #32406
Conversation
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description:
This PR contains a few changes:
context.Background
shouldn't be referenced except for tests here, as it opens the door to possible leaks. This was done forECSInfo
andHostInfo
.defer
calls to shutdown to be inside anonymous func to ensure they're not called until the defer is actually executed.goleak
checks on the remaining internal packages of the AWS Container Insights receiver to help ensure no goroutines are being leaked.Link to tracking Issue:
#30438
Testing:
All existing tests are passing, as well as added
goleak
checks