Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] vcenterreceiver: Updates mockserver responses for better VM Resource Pool attributes #32448

Merged

Conversation

StefanKurek
Copy link
Contributor

@StefanKurek StefanKurek commented Apr 16, 2024

Description:
Minor change. VMs (not templates) typically have Resource Pool attributes associated with them, and the mockserver responses were not reflecting this for the unit tests. Updated the tests to reflect this.

Link to tracking Issue:
N/A

Testing:
Unit tests updated and still working

Documentation:
N/A

@StefanKurek StefanKurek requested a review from djaglowski as a code owner April 16, 2024 16:18
@StefanKurek StefanKurek requested a review from a team April 16, 2024 16:18
@github-actions github-actions bot requested a review from schmikei April 16, 2024 16:19
@StefanKurek StefanKurek force-pushed the feat/update-vcenterreceiver-tests branch 2 times, most recently from 5502fa3 to 7795a1d Compare April 16, 2024 16:21
@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 16, 2024
@StefanKurek StefanKurek force-pushed the feat/update-vcenterreceiver-tests branch from 5d6fe6e to 2a70bbb Compare April 16, 2024 17:29
@djaglowski djaglowski merged commit 941f828 into open-telemetry:main Apr 16, 2024
156 checks passed
@djaglowski
Copy link
Member

Thanks @StefanKurek

@github-actions github-actions bot added this to the next release milestone Apr 16, 2024
@StefanKurek StefanKurek deleted the feat/update-vcenterreceiver-tests branch April 16, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
receiver/vcenter Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants