Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jmacd@ as owner of probabilisticsamplerprocessor #32461

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Apr 16, 2024

Description: This component has only one maintainer, and I have become very familiar with the component's code.

#32360
#31946
#31894

Documentation: n/a

@jmacd jmacd requested review from a team and MovieStoreGuy April 16, 2024 18:57
@jmacd jmacd added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 16, 2024
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to add your username to the component's metadata.yaml file as well, and then run make update-codeowners. Here's the docs reference in case the make command fails.

@jmacd jmacd requested a review from jpkrohling as a code owner April 16, 2024 19:51
@github-actions github-actions bot added the processor/probabilisticsampler Probabilistic Sampler processor label Apr 16, 2024
@dmitryax dmitryax merged commit 4285742 into open-telemetry:main Apr 16, 2024
156 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 16, 2024
@jpkrohling
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/probabilisticsampler Probabilistic Sampler processor Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants