-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore][CI/CD] Remove integration test naming restriction #32529
[chore][CI/CD] Remove integration test naming restriction #32529
Conversation
I've filed #32715 for the failing CI/CD action, it's unrelated to this PR. |
Added |
…32717) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This fixes 2/3 failing integration tests in #32543. The last failing test `TestAlertsReceiverTLS` needs to be skipped for now, as its cert files are invalid and need to be re-generated. All three of these tests are currently being skipped, but will run again when #32529 is merged. **Link to tracking Issue:** <Issue number if applicable> #32529 #32543 **Testing:** <Describe what testing was performed and which tests were added.> Two tests are passing again locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the conflict, note that the PR that needed to be merged to remove skipping a test has also been merged
Co-authored-by: Antoine Toulme <antoine@toulme.name>
I've resolved the conflict and updated other tests based on more merged PRs. This should be ready (pending passing CI/CD). |
Description:
Including the
-run=Integration
argument in themake
command means that only integration tests that includeIntegration
in their name will be run. This requirement is not obvious to users, so there are currently around 15 integration tests that aren't being run because they don't conform to this requirement. I think the best approach here is to remove the-run
argument (rather than rename tests) so that this doesn't happen again.Link to tracking Issue:
Resolves #32207