[exporter/awskinesisexporter] fix in compressor crashing under heady load due non-safe thread execution #32589
Conversation
…ression execution
There was a problem hiding this comment.
Considering that this is intended to resolve a potential race condition, if we can look at ensuring that this can not happen again with tests, or ensure that operations are atomic is the ideal here.
Could you help provide some additional tests, or protections that this will stop happening?
…com:leorinat/opentelemetry-collector-contrib into fix/compressor-kinesis-exporter-thread-safe # Conflicts: # exporter/awskinesisexporter/internal/compress/compresser.go # exporter/awskinesisexporter/internal/compress/noop_compression.go
| ) | ||
|
|
||
| type bufferedResetWriter interface { |
It looks like there's a test that might satisfy this requirement here: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/32589/files#diff-280135a7ba6930827a3944b3ac3fdc236eed9dc619c336dd817d22c4bd73dc9cR125 |
Fixing a bug that made the execution panic when the load was high enough, specially if the payloads were not very tiny.
Testing:
Executed this with and without the fix locally using heavy load, then ran it in cloud servers using heavier load and a variety of payloads.