Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[telemetrygen] Add support to set metric name #32840

Merged
merged 1 commit into from
May 3, 2024
Merged

[telemetrygen] Add support to set metric name #32840

merged 1 commit into from
May 3, 2024

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested a review from a team May 2, 2024 23:17
@bogdandrutu
[telemetrygen] Add support to set metric name
626be21 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@github-actions github-actions bot added the cmd/telemetrygen telemetrygen command label May 2, 2024
atoulme
atoulme approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@atoulme atoulme left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing the assertions too.

Maybe as a separate PR or a new issue, we should track documenting all options in README. There are quite a few that are not documented now.

@bogdandrutu bogdandrutu merged commit ed4adf7 into open-telemetry:main May 3, 2024
162 checks passed
@github-actions github-actions bot added this to the next release milestone May 3, 2024
@bogdandrutu bogdandrutu deleted the bdrutu-add-metric-name branch May 3, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@atoulme atoulme atoulme approved these changes

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

@codeboten codeboten Awaiting requested review from codeboten codeboten is a code owner

Assignees

@mx-psi mx-psi

Labels
cmd/telemetrygen telemetrygen command
Projects
None yet
Milestone
v0.100.0
Development

Successfully merging this pull request may close these issues.
4 participants
@bogdandrutu @atoulme @dmitryax @mx-psi