Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote rabbitmqexporter to alpha #33331

Merged

Conversation

swar8080
Copy link
Contributor

@swar8080 swar8080 commented Jun 2, 2024

Description:
Promotes the RabbitMQ exporter to alpha

Testing:
Manual testing and integration tests implemented in a previous PR

@swar8080 swar8080 requested a review from atoulme as a code owner June 2, 2024 18:44
@swar8080 swar8080 requested a review from a team June 2, 2024 18:44
@swar8080 swar8080 force-pushed the rabbitmqexporter-alpha-promotion branch 3 times, most recently from 17d09a0 to bc110df Compare June 2, 2024 18:46
@swar8080 swar8080 requested review from mx-psi and dmitryax as code owners June 2, 2024 20:05
@github-actions github-actions bot added the cmd/configschema configschema command label Jun 2, 2024
@mx-psi
Copy link
Member

mx-psi commented Jun 3, 2024

Should this be a draft PR based on the title? If so, can you mark it as draft using the link below the reviewers list?
image

@swar8080 swar8080 force-pushed the rabbitmqexporter-alpha-promotion branch from 1a888d5 to 890cc7c Compare June 9, 2024 16:49
@swar8080 swar8080 marked this pull request as draft June 9, 2024 19:55
@swar8080 swar8080 changed the title Draft: promote rabbitmqexporter to alpha Promote rabbitmqexporter to alpha Jun 9, 2024
@swar8080 swar8080 marked this pull request as ready for review June 9, 2024 20:20
Copy link
Contributor

@fatsheep9146 fatsheep9146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Jun 12, 2024
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swar8080 when you have a second to rebase, we can get this merged shortly after

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinging other code owner to confirm: @atoulme

@swar8080
Copy link
Contributor Author

Hi @atoulme, this seems ready to merge once you approve

| Issues | [![Open issues](https://img.shields.io/github/issues-search/open-telemetry/opentelemetry-collector-contrib?query=is%3Aissue%20is%3Aopen%20label%3Aexporter%2Frabbitmq%20&label=open&color=orange&logo=opentelemetry)](https://github.com/open-telemetry/opentelemetry-collector-contrib/issues?q=is%3Aopen+is%3Aissue+label%3Aexporter%2Frabbitmq) [![Closed issues](https://img.shields.io/github/issues-search/open-telemetry/opentelemetry-collector-contrib?query=is%3Aissue%20is%3Aclosed%20label%3Aexporter%2Frabbitmq%20&label=closed&color=blue&logo=opentelemetry)](https://github.com/open-telemetry/opentelemetry-collector-contrib/issues?q=is%3Aclosed+is%3Aissue+label%3Aexporter%2Frabbitmq) |
| [Code Owners](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#becoming-a-code-owner) | [@swar8080](https://www.github.com/swar8080), [@atoulme](https://www.github.com/atoulme) |

[development]: https://github.com/open-telemetry/opentelemetry-collector#development
[alpha]: https://github.com/open-telemetry/opentelemetry-collector#alpha
[contrib]: https://github.com/open-telemetry/opentelemetry-collector-releases/tree/main/distributions/otelcol-contrib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to add it in opentelemetry-releases

@TylerHelmuth TylerHelmuth merged commit c3f6645 into open-telemetry:main Jul 1, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command exporter/rabbitmq ready to merge Code review completed; ready to merge by maintainers reports/distributions/contrib.yaml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants