[extension/healthcheck] remove broken code #33470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the dependency on opencensus by removing the code that sets up a view to trigger healthcheck status changes. This functionality does not work as documented in the README: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/extension/healthcheckextension#health-check I'm proposing to remove the code that brings an unnecessary dependency for functionality that isn't working. Fixes open-telemetry#33469 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
jpkrohling
approved these changes
Jun 11, 2024
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency on opencensus by removing the code that sets up a view to trigger healthcheck status changes. This functionality does not work as documented in the README: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/extension/healthcheckextension#health-check
I'm proposing to remove the code that brings an unnecessary dependency for functionality that isn't working.
Fixes #33469
As discussed previously #29782, an improved functionality will be implemented in the v2 healthcheck extension