Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to OTel-Arrow v0.24.0 deps #33518

Merged
merged 5 commits into from
Jun 13, 2024
Merged

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Jun 12, 2024

Description:
This is a copy of the otel-arrow repository exporter and receiver components at
open-telemetry/otel-arrow@dd6e224

Updates both go.mods to OTel-Arrow v0.24.0 dependencies, the current release.

Applies repo-specific make gci logic.

Link to tracking Issue: #26491

Testing: Passing

Documentation: n/a

@jmacd jmacd marked this pull request as ready for review June 12, 2024 20:15
@jmacd jmacd requested a review from a team June 12, 2024 20:15
@jmacd
Copy link
Contributor Author

jmacd commented Jun 12, 2024

(The test failures look unrelated.)

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, they're related to #33520

Copy link
Contributor

@moh-osman3 moh-osman3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmacd. Will there be much more work on the receiver/exporter that requires it to be done in multiple repositories or could most of the work be done in this repo?

Reason I'm asking is that it's difficult to catch up on all the changes in a single PR review. And I'm guessing doing the work in multiple places sucks too :)

receiver/otelarrowreceiver/config.go Show resolved Hide resolved
Copy link
Contributor Author

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codeboten Thanks! Re: #33518 (review), yes ... yes.

I filed open-telemetry/otel-arrow#225 to record this intention. We will remove the exporter and receiver components from that repository as soon as they are merged in this PR.

receiver/otelarrowreceiver/config.go Show resolved Hide resolved
@codeboten codeboten merged commit 71bb4b0 into open-telemetry:main Jun 13, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Jun 13, 2024
@jmacd jmacd deleted the jmacd/arrow24up branch June 14, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants