[cmd/opampsupervisor] Forward custom messages to/from agent #33576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
atoulme,
evan-bradley and
tigrannajaryan
djaglowski
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
This generally looks good to me. I'd appreciate a review from @evan-bradley as well though.
evan-bradley
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Sorry for the delay, this looks good to me. Thanks @djaglowski for taking a look.
@tigrannajaryan I'll leave this open in case you want to take a look, otherwise I'll merge this by Friday if I am able, or next Monday at the latest.
BinaryFissionGames
force-pushed
the
feat/supervisor-passthrough-custom-capabilities
branch
from
bb75b96
to
76a82ba
Compare
|
@tigrannajaryan Gentle bump on this, it's ready for re-review when you get a chance 😄 |
@BinaryFissionGames I am out this week, won't be able to review. Please feel free to merge, no need to wait for me. |
mx-psi
pushed a commit
that referenced
this pull request
Sep 11, 2024
**Description:** Follow-up to #33576. Boolean short-circuiting was causing the `onMessage` handler to not process the whole `ServerToAgent` message if it included multiple fields. I noticed this was causing the Collector to fail to start when using the opamp-go demo server; the own metrics section is required for the Collector to start since it provides the only pipelines by default. I included a new unit test that verifies everything looks as we would expect when getting a message like what would be sent by the example server. --------- Co-authored-by: Evan Bradley <evan-bradley@users.noreply.github.com>
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…telemetry#34349) **Description:** Follow-up to open-telemetry#33576. Boolean short-circuiting was causing the `onMessage` handler to not process the whole `ServerToAgent` message if it included multiple fields. I noticed this was causing the Collector to fail to start when using the opamp-go demo server; the own metrics section is required for the Collector to start since it provides the only pipelines by default. I included a new unit test that verifies everything looks as we would expect when getting a message like what would be sent by the example server. --------- Co-authored-by: Evan Bradley <evan-bradley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue: Closes #33575
Testing: