Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/doris] New component: Doris Exporter #33790

Merged
merged 25 commits into from
Aug 27, 2024

Conversation

joker-star-l
Copy link
Contributor

Description:

First PR of New component: Doris Exporter.

Link to tracking Issue:

#33479

Testing:

Documentation:

Copy link

linux-foundation-easycla bot commented Jun 27, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@atoulme
Copy link
Contributor

atoulme commented Jun 28, 2024

I think you can get this in quickly if you remove the impl code you have in there, and keep to the skeleton, and we can discuss the schema creation in a different PR.

@atoulme
Copy link
Contributor

atoulme commented Jun 28, 2024

Please add a changelog as well. See make chlog-new in root to generate changelog.

@joker-star-l
Copy link
Contributor Author

Please add a changelog as well. See make chlog-new in root to generate changelog.

Thanks for your suggestions above, I have changed the code.

@joker-star-l joker-star-l marked this pull request as ready for review July 3, 2024 07:04
@joker-star-l joker-star-l requested a review from a team July 3, 2024 07:04
@atoulme
Copy link
Contributor

atoulme commented Jul 11, 2024

Please feel free to resolved outdated threads. It looks like you're close.

@joker-star-l
Copy link
Contributor Author

Please feel free to resolved outdated threads. It looks like you're close.

Ok, thank you.

@joker-star-l
Copy link
Contributor Author

@atoulme @AlchemyDing Hello, all checks have passed. Are there any other problems with the code? Can it be merged?

@joker-star-l
Copy link
Contributor Author

@atoulme Hello, are there any problems with this pr? Sorry to bother you again.

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label Aug 27, 2024
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joker-star-l, have you already applied to become a member of the opentelemetry organization?

@codeboten codeboten merged commit ec83b46 into open-telemetry:main Aug 27, 2024
161 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 27, 2024
@joker-star-l
Copy link
Contributor Author

Thanks @joker-star-l, have you already applied to become a member of the opentelemetry organization?

Not yet. Could you tell me how to apply to become a member? I will contribute and support this component. If I understand correctly, from the CONTRIBUTING.md, I need to become a member.

@codeboten
Copy link
Contributor

f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this pull request Sep 12, 2024
First PR of New component: Doris Exporter.

**Link to tracking Issue:** open-telemetry#33479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/githubgen ready to merge Code review completed; ready to merge by maintainers reports/distributions/contrib.yaml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants