-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/doris] New component: Doris Exporter #33790
Conversation
I think you can get this in quickly if you remove the impl code you have in there, and keep to the skeleton, and we can discuss the schema creation in a different PR. |
Please add a changelog as well. See |
Thanks for your suggestions above, I have changed the code. |
Please feel free to resolved outdated threads. It looks like you're close. |
Ok, thank you. |
@atoulme @AlchemyDing Hello, all checks have passed. Are there any other problems with the code? Can it be merged? |
@atoulme Hello, are there any problems with this pr? Sorry to bother you again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @joker-star-l, have you already applied to become a member of the opentelemetry organization?
Not yet. Could you tell me how to apply to become a member? I will contribute and support this component. If I understand correctly, from the CONTRIBUTING.md, I need to become a member. |
For sure, see the following for more details: |
First PR of New component: Doris Exporter. **Link to tracking Issue:** open-telemetry#33479
Description:
First PR of New component: Doris Exporter.
Link to tracking Issue:
#33479
Testing:
Documentation: