[pkg/stanza] handle errors from Operator.Process

[zeitlinger]

Link to tracking Issue: Fixes #33783

Testing:

nothing added

Documentation:

not applicable

[zeitlinger]

seems some tests expect some errors to be ignored

Test:

opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/header/reader_test.go

Line 75 in d78d7bb

assert.NoError(t, reader.Process(context.Background(), []byte("# matches header regex but not metadata operator assumptions\n"), attrs))

Error that now shows:

opentelemetry-collector-contrib/pkg/stanza/operator/parser/keyvalue/parser.go

Line 31 in 5c7e342

return p.parser(m, p.delimiter, p.pairDelimiter)

[djaglowski]

Generally looks good to me

[zeitlinger]

seems some tests expect some errors to be ignored

Test:

opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/header/reader_test.go

Line 75 in d78d7bb

assert.NoError(t, reader.Process(context.Background(), []byte("# matches header regex but not metadata operator assumptions\n"), attrs))

Error that now shows:

opentelemetry-collector-contrib/pkg/stanza/operator/parser/keyvalue/parser.go

Line 31 in 5c7e342

return p.parser(m, p.delimiter, p.pairDelimiter)

here's what I tried - but I'm not sure this is the right path - and it's not working

Subject: [PATCH] add example for using recombine in container operator
---
Index: pkg/stanza/operator/helper/parser.go
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/pkg/stanza/operator/helper/parser.go b/pkg/stanza/operator/helper/parser.go
--- a/pkg/stanza/operator/helper/parser.go	(revision d5550419676f27a422bb0d2f44e1667aec318a01)
+++ b/pkg/stanza/operator/helper/parser.go	(date 1720096829632)
@@ -91,6 +91,7 @@
 	SeverityParser  *SeverityParser
 	TraceParser     *TraceParser
 	ScopeNameParser *ScopeNameParser
+	IgnoreErrors    bool
 }
 
 // ProcessWith will run ParseWith on the entry, then forward the entry on to the next operators.
@@ -105,7 +106,7 @@
 		return p.HandleEntryError(ctx, entry, err)
 	}
 	if skip {
-		return p.Write(ctx, entry)
+		return p.write(ctx, entry)
 	}
 
 	if err = p.ParseWith(ctx, entry, parse); err != nil {
@@ -118,7 +119,15 @@
 		}
 	}
 
-	return p.Write(ctx, entry)
+	return p.write(ctx, entry)
+}
+
+func (p *ParserOperator) write(ctx context.Context, entry *entry.Entry) error {
+	err := p.Write(ctx, entry)
+	if p.IgnoreErrors {
+		return nil
+	}
+	return err
 }
 
 // ParseWith will process an entry's field with a parser function.
Index: pkg/stanza/fileconsumer/internal/header/config.go
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/pkg/stanza/fileconsumer/internal/header/config.go b/pkg/stanza/fileconsumer/internal/header/config.go
--- a/pkg/stanza/fileconsumer/internal/header/config.go	(revision d5550419676f27a422bb0d2f44e1667aec318a01)
+++ b/pkg/stanza/fileconsumer/internal/header/config.go	(date 1720096829384)
@@ -8,6 +8,7 @@
 	"bytes"
 	"errors"
 	"fmt"
+	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/keyvalue"
 	"regexp"
 
 	"go.opentelemetry.io/collector/component"
@@ -62,6 +63,11 @@
 		if op.Type() == "filter" {
 			return nil, fmt.Errorf("operator of type filter is not allowed in `metadata_operators`")
 		}
+
+		if op.Type() == "key_value_parser" {
+			parser, _ := op.(*keyvalue.Parser)
+			parser.IgnoreErrors = true
+		}
 	}
 
 	regex, err := regexp.Compile(matchRegex)

if we can't figure this out, then maybe the approach is wrong

[djaglowski]

@zeitlinger, I pushed a minor change to the way the header parser processes errors. I think we just need the changelog now