-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/prometheus] feat: add Prometheus API server #33875
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm otherwise
Sorry for the slow review. Getting back from vacation |
FYI @jesusvazquez |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Thanks @dashpole I have taken the latest and things look good with the changes. For all the tests to pass, running |
Please resolve conflicts? |
Please resolve conflicts. All go.mod files of other components should not be touched, afaict. |
Resolved the conflicts, but the other go.mod files seem to be due to those also depending on the prometheusreceiver in the go.mod, so it's adding indirect dependencies to those files and the go.sum files |
Thanks @atoulme all tests are passing and there aren't any merge conflicts right now |
Description:
This is a new PR instead of this one: #32646 which has more relevant discussion.
This PR adds the Prometheus API server as part of the Prometheus receiver if enabled through the receiver config.
It supports calling the
/config
,/targets
,/targets/metadata
,/scrape_pools
, and/metrics
paths for more debugging information about the underlying Prometheus scrape manager and discovery manager.Link to tracking Issue:
open-telemetry/prometheus-interoperability-spec#63
Testing:
Added tests for the prometheus receiver configuration, for each path that the API supports, and for the server shutting down correctly. Also tested out with running the opentelemetry-collector agent with the prometheus receiver.
Documentation:
Added to the prometheus receiver README about how to configure the setting.