Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awss3receiver: Remove use of deprecated AWS SDK v2 API #34171

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

adcharre
Copy link
Contributor

Description: Remove use of deprecated AWS SDK v2 Endpoint resolver API

Link to tracking Issue: #30750

Testing: Tested against a locally running localstack instance.

Documentation: N/A

@adcharre adcharre requested a review from atoulme as a code owner July 19, 2024 13:59
@adcharre adcharre requested a review from a team July 19, 2024 13:59
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this impact the user in any way? If there's no change for users we can remove the changelog.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope - no change for the user - implementation only.

@crobert-1 crobert-1 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 22, 2024
@crobert-1 crobert-1 added the ready to merge Code review completed; ready to merge by maintainers label Jul 22, 2024
@codeboten codeboten merged commit 14923a8 into open-telemetry:main Jul 25, 2024
168 of 170 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers receiver/awss3 Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants