Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][internal/otelarrow] Unskip test #34391

Merged
merged 1 commit into from
Aug 6, 2024
Merged

[chore][internal/otelarrow] Unskip test #34391

merged 1 commit into from
Aug 6, 2024

Conversation

crobert-1
Copy link
Member

Description:

This reverts #34362 as #34260 was merged to resolve the test. The flakiness should be resolved so we no longer need to skip this test.

@crobert-1 crobert-1 requested a review from jmacd as a code owner August 2, 2024 14:52
@crobert-1 crobert-1 requested review from a team and evan-bradley August 2, 2024 14:52
@github-actions github-actions bot requested a review from moh-osman3 August 2, 2024 14:52
@crobert-1 crobert-1 mentioned this pull request Aug 2, 2024
Merged
axw
axw approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @crobert-1!

@mwear mwear added the ready to merge Code review completed; ready to merge by maintainers label Aug 6, 2024
@github-actions github-actions bot mentioned this pull request Aug 6, 2024
Closed
@mx-psi mx-psi added the Run Windows Enable running windows test on a PR label Aug 6, 2024
@mx-psi mx-psi merged commit e982922 into open-telemetry:main Aug 6, 2024
185 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjanotti pjanotti pjanotti approved these changes

@mwear mwear mwear approved these changes

@axw axw axw approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@evan-bradley evan-bradley Awaiting requested review from evan-bradley

@moh-osman3 moh-osman3 Awaiting requested review from moh-osman3

Assignees

@fatsheep9146 fatsheep9146

Labels
internal/otelarrow ready to merge Code review completed; ready to merge by maintainers Run Windows Enable running windows test on a PR
Projects
None yet
Milestone
v0.107.0
Development

Successfully merging this pull request may close these issues.
6 participants
@crobert-1 @axw @mwear @pjanotti @mx-psi @fatsheep9146