[receiver/solacereceiver]: Updated the format for generated metrics and included new Solace receiver metric attribute #34541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcardy
approved these changes
Aug 8, 2024
djaglowski
approved these changes
Aug 9, 2024
|
Seems there's still an error to resolve: |
|
Thanks @djaglowski, I have ran |
|
Sorry I see some tests errors, I will fix them now. |
|
Thanks @djaglowski! |
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
…nd included new Solace receiver metric attribute (open-telemetry#34541) **Description:** Updated the format for generated metrics. Included a `receiver_name` attribute that identifies the Solace receiver that generated the metrics. **Link to tracking Issue:** N/A **Testing:** Updated unit tests to accommodate passing of attributes for metrics **Documentation:** N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Updated the format for generated metrics. Included a
receiver_nameattribute that identifies the Solace receiver that generated the metrics.Link to tracking Issue: N/A
Testing: Updated unit tests to accommodate passing of attributes for metrics
Documentation: N/A