Add IsMatchVersion convertor to pkg/ottl. #34647
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boh-dan
requested review from
TylerHelmuth,
bogdandrutu and
evan-bradley
as code owners
|
|
@boh-dan please open an issue describing your problem so we can discuss this potential function addition. |
|
@TylerHelmuth just added into the description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add IsMatchVersion converter to the pkg/ottl.
IsMatchVersion should help in situations where a specific version of the application or instrumentation is targeted. The author came across a situation where an old version of the mobile application is sending an incorrect telemetry and there is no other way to filter out the telemetry except using the application version. The solution is based on the go semver library that provides all required functionality to parse a semver version and validate against constraint.
Testing: unit tests and e2e test
Issue: #34674
Documentation: A new README entry was added for the IsMatchVersion function.