chore: remove config Validate call in docker #34699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skip changelog? |
rogercoll
commented
Aug 15, 2024
Comment on lines
-59
to
-64
| if config.Endpoint == "" { | ||
| return errors.New("config.Endpoint must be specified") | ||
| } | ||
| if err := VersionIsValidAndGTE(config.DockerAPIVersion, minimumRequiredDockerAPIVersion); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
This is already being validated by each components Validate:
|
cc @mx-psi |
mx-psi
reviewed
Aug 20, 2024
rogercoll
force-pushed
the
remove_validate_call_docker
branch
from
3d6a7e9 to
6dfd875
Compare
mx-psi
approved these changes
Aug 21, 2024
| return err | ||
| } | ||
| return nil | ||
|
|
||
| if len(config.ExcludedImages) == 0 { |
There was a problem hiding this comment.
I am not certain this is strictly needed, zero and empty lists are effectively the same when iterating over them.
There was a problem hiding this comment.
I agree, I added this check to keep the PR nop. The component's configuration test expect a nil list but the inner Unmarshal is now returning an empty one. If prefered, I can readapt the test to assert an empty list.
MovieStoreGuy
approved these changes
Aug 28, 2024
|
@rogercoll can you fix CI? we can merge after that |
@mx-psi Fixed 👍 Thanks for the heads up |
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Configuration validation is done during collector's startup, making it redundant when being called inside component's logic. This PR removes the Validate call done during Dockers's receiver start function. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#33498 **Testing:** <Describe what testing was performed and which tests were added.> No testing needed to be modified as the `Validate` functionality is already covered. **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Configuration validation is done during collector's startup, making it redundant when being called inside component's logic. This PR removes the Validate call done during Dockers's receiver start function.
Link to tracking Issue:
#33498
Testing:
No testing needed to be modified as the
Validatefunctionality is already covered.Documentation: