[chore] Update otel #34721
Merged
[chore] Update otel #34721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Signed-off-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
github-actions
bot
added
cmd/githubgen
cmd/opampsupervisor
cmd/otelcontribcol
TylerHelmuth
requested review from
crobert-1,
dashpole,
atoulme,
jmacd,
dmitryax,
codeboten,
fatsheep9146,
jpkrohling,
yurishkuro,
mx-psi,
bogdandrutu,
evan-bradley,
tigrannajaryan,
mwear,
jsuereth,
songy23 and
bryan-aguilar
as code owners
|
@mwear I got healthcheckv2extension building and tests passing, but did not dig deeper than that. |
dmitryax
approved these changes
Aug 16, 2024
mwear
approved these changes
Aug 16, 2024
songy23
approved these changes
Aug 16, 2024
|
We can merge this to unblock core tests and block the release via #34723 |
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
Updates the core modules to use the latest changes that remove component status feature from `component`. All references to status features from `component` have been updated to `componentstatus`. Unlike core's implementation of `SharedComponent`, contrib's implementation had no component status features. I believe contrib's `ShareComponent` implementation should be updated, but that can now be added in a separate PR since it already wasn't supporting component status reporting. --------- Signed-off-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the core modules to use the latest changes that remove component status feature from
component.All references to status features from
componenthave been updated tocomponentstatus.Unlike core's implementation of
SharedComponent, contrib's implementation had no component status features. I believe contrib'sShareComponentimplementation should be updated, but that can now be added in a separate PR since it already wasn't supporting component status reporting.