[processor/deltatocumulative]: linear pipeline #34757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh0rez
force-pushed
the
deltatocumulative-linear
branch
from
e3ec884
to
9de4074
Compare
|
no changelog needed imo |
sh0rez
force-pushed
the
deltatocumulative-linear
branch
from
9de4074
to
e9e38ce
Compare
Transforms the processors main logic from a deeply-nested, map structure that overloads the Store operation to a strongly decoupled, linear processing flow that nearly entirely happens within `ConsumeMetrics`, greatly improving understandability of the code
moves most tests from `internal/delta` to the processor itself, excercising the public api.
hides types from public api that don't need to be public
adds summary datatype to make type switch exhaustive
sh0rez
force-pushed
the
deltatocumulative-linear
branch
from
85c35c5
to
d182712
Compare
|
Hey @sh0rez, I'd love to help you out here but I'm new to the codebase and 2k line changes might be a bit too much for my first review 😅 Do you think you could break this PR into smaller ones? Or maybe you could tell me the biggest problems of the current codebase, I could try to come up with the refactoring myself and you review? The options above are just to unblock you, if you think you can progress without my help please do so :) |
|
Closing in favor of #35048 |
jpkrohling
pushed a commit
that referenced
this pull request
Sep 27, 2024
**Description:** Partially introduces a highly decoupled, linear processing pipeline. Implemented as a standalone struct to make review easier, will refactor this later. Instead of overloading `Map.Store()` to do aggregation, staleness and limiting, this functionality is now explcitly handled in `ConsumeMetrics`. This highly aids readability and makes understanding this processor a lot easier, as less mental context needs to be kept. *Notes to reviewer*: See [`68dc901`](68dc901) for the main added logic. Compare `processor.go` (old, nested) to `linear.go` (new, linear) Replaces #34757 **Link to tracking Issue:** none **Testing:** This is a refactor. Existing tests were not modified and still pass **Documentation:** not needed
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…#35048) **Description:** Partially introduces a highly decoupled, linear processing pipeline. Implemented as a standalone struct to make review easier, will refactor this later. Instead of overloading `Map.Store()` to do aggregation, staleness and limiting, this functionality is now explcitly handled in `ConsumeMetrics`. This highly aids readability and makes understanding this processor a lot easier, as less mental context needs to be kept. *Notes to reviewer*: See [`68dc901`](open-telemetry@68dc901) for the main added logic. Compare `processor.go` (old, nested) to `linear.go` (new, linear) Replaces open-telemetry#34757 **Link to tracking Issue:** none **Testing:** This is a refactor. Existing tests were not modified and still pass **Documentation:** not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Refactors the high-level pipeline to lower general complexity.
Before:
streams.Mapbased pipelineMap.StoremethodsAfter:
ConsumeMetricsthat ties together staleness, limits, accumulation, etc.Link to tracking Issue: none
Testing: Existing tests were adapted to new architecture
Documentation: not needed