[sumconnector] implement summing logic #34797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
reviewed
Aug 23, 2024
…rname/opentelemetry-collector-contrib into 32669-sumconnector-sum-logic
…rname/opentelemetry-collector-contrib into 32669-sumconnector-sum-logic
atoulme
reviewed
Sep 4, 2024
revert change from `make genotelcontribcol` Co-authored-by: Antoine Toulme <antoine@toulme.name>
crobert-1
reviewed
Sep 5, 2024
crobert-1
approved these changes
Sep 11, 2024
|
Thanks for the approval! README whitespace nits addressed. |
|
@crobert-1 Is there anyone else I need approvals from or just waiting for someone to merge in the next round? |
crobert-1
added
the
ready to merge
We should be good, I've added |
|
Thanks!!! |
andrzej-stencel
changed the title
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
**Description:** - Adds connector and summing logic - Adds testing of traces and spans summing Note: testing and test data makes up the bulk of the lines in this PR **Link to tracking Issue:** 32669 **Testing:** - condition, attribute, default attribute, multiple condition, multiple attributes, multiple metrics for traces / spans telemetry types **Documentation:** No new docs --------- Co-authored-by: Antoine Toulme <antoine@toulme.name>
mx-psi
pushed a commit
that referenced
this pull request
Oct 7, 2024
…ata) (#35434) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Adds tests for metrics to metrics and logs to metrics follows this pr: #34797 This is a lot of lines but it is mostly repetition and uses the same standard structure as the previously merged trace to metric tests. I dont think this needs any changelog but let me know if it does for some reason! 😸 **Link to tracking Issue:** #32669 **Testing:** <Describe what testing was performed and which tests were added.> Adds testing for metrics to metrics and logs to metrics using same methodology as previous PR **Documentation:** No changes to docs. This is just tests. --------- Co-authored-by: Curtis Robert <crobert@splunk.com>
Eromosele-SM
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2024
…ata) (open-telemetry#35434) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Adds tests for metrics to metrics and logs to metrics follows this pr: open-telemetry#34797 This is a lot of lines but it is mostly repetition and uses the same standard structure as the previously merged trace to metric tests. I dont think this needs any changelog but let me know if it does for some reason! 😸 **Link to tracking Issue:** open-telemetry#32669 **Testing:** <Describe what testing was performed and which tests were added.> Adds testing for metrics to metrics and logs to metrics using same methodology as previous PR **Documentation:** No changes to docs. This is just tests. --------- Co-authored-by: Curtis Robert <crobert@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Note: testing and test data makes up the bulk of the lines in this PR
Link to tracking Issue: 32669
Testing:
Documentation: No new docs