New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/kafkareceiver] Add otlp_json support in kafka receiver #34840

Merged

mx-psi merged 14 commits into open-telemetry:main from joeyyy09:otlp_logs

Sep 16, 2024

Contributor

joeyyy09 commented Aug 26, 2024 •

edited

Loading

Description:

The current features dont support otlp_json in receivers/kafkareceivers.

Add support for otlp_json which accepts json formated for Otel Collector kafka receiver
Link to tracking Issue: #33627

Testing:
Added test files for the same.

Documentation:


          Add otlp_json support in kafka receiver

5251b71

Signed-off-by: joeyyy09 <menteharshith@gmail.com>

github-actions bot added the receiver/kafka label

github-actions bot requested review from MovieStoreGuy and pavolloffay

August 26, 2024 05:27

joeyyy09 changed the title ~~Add otlp_json support in kafka receiver~~ [receiver/kafkareceiver] Add otlp_json support in kafka receiver

Contributor Author

joeyyy09 commented Aug 26, 2024 •

edited

Loading

this is a draft in process, would love to see if im going in the right direction or not.

joeyyy09 added 2 commits

August 26, 2024 11:59


          Add otlp_json support in kafka receiver

237c0a5

Signed-off-by: joeyyy09 <menteharshith@gmail.com>


          Update tests and documentation

96a41ed

Signed-off-by: joeyyy09 <menteharshith@gmail.com>

yurishkuro reviewed

View reviewed changes

receiver/kafkareceiver/unmarshaler.go Outdated Show resolved Hide resolved

receiver/kafkareceiver/README.md Outdated Show resolved Hide resolved

joeyyy09 added 2 commits

August 26, 2024 19:59


          Add support for metrics, logs

2f3cef0

Signed-off-by: joeyyy09 <menteharshith@gmail.com>


          Add changelog entry for otlp_json support in Kafka receiver

a6a5d57

yurishkuro reviewed

View reviewed changes

receiver/kafkareceiver/unmarshaler.go Outdated Show resolved Hide resolved


          Maintain consistency

5d0b742

Signed-off-by: joeyyy09 <menteharshith@gmail.com>

joeyyy09 marked this pull request as ready for review

August 27, 2024 05:02

joeyyy09 requested a review from a team

August 27, 2024 05:02

github-actions bot assigned fatsheep9146


          Instantiate inline

ba7e5a0

Signed-off-by: joeyyy09 <menteharshith@gmail.com>

yurishkuro approved these changes

View reviewed changes


          Merge branch 'main' into otlp_logs

Member

yurishkuro commented Sep 3, 2024

@joeyyy09 check the linter failures
kafkareceiver/unmarshaler.go:61: File is not gci-ed with --skip-generated -s standard -s default -s prefix(github.com/open-telemetry/opentelemetry-collector-contrib) (gci)


          Lint fix

4d2ca67

Signed-off-by: joeyyy09 <menteharshith@gmail.com>

Contributor Author

joeyyy09 commented Sep 3, 2024

@joeyyy09 check the linter failures kafkareceiver/unmarshaler.go:61: File is not gci-ed with --skip-generated -s standard -s default -s prefix(github.com/open-telemetry/opentelemetry-collector-contrib) (gci)

My bad, fixed that.


          Merge branch 'main' into otlp_logs

b01b633

fatsheep9146 approved these changes

View reviewed changes

receiver/kafkareceiver/README.md Outdated Show resolved Hide resolved

joeyyy09 and others added 3 commits

September 9, 2024 18:31


          Merge branch 'main' into otlp_logs

0f4e164


          nit fix

40ac6c3


          Merge branch 'main' into otlp_logs

f83cac6

yurishkuro approved these changes

View reviewed changes

Contributor

thmshmm commented Sep 13, 2024

Support for encoding extensions in the kafkareceiver was just merged with #33888. Using the otlpencodingextension should now do the job.


          Merge branch 'main' into otlp_logs

e8e8d23

Member

yurishkuro commented Sep 13, 2024

Prom tests are failing on main, not an issue here (#35119). Everything else in the PR is green. @open-telemetry/collector-maintainers this can be merged.

@thmshmm I think an upgrade to otlpencodingextension is an independent issue and can be tackled separately, there's no need for it to block this PR.

mx-psi merged commit 01c6651 into open-telemetry:main

155 of 156 checks passed

github-actions bot added this to the next release milestone

atoulme mentioned this pull request

[kafkareceiver] add support for otlp_json which accepts json formated for Otel Collector kafka receiver #33627

Closed

jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this pull request


          [receiver/kafkareceiver] Add otlp_json support in kafka receiver (ope…

658c836

…n-telemetry#34840)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.

Ex. Adding a feature - Explain what this achieves.-->The current
features dont support otlp_json in receivers/kafkareceivers.
Add support for otlp_json which accepts json formated for Otel Collector
kafka receiver
**Link to tracking Issue:** <Issue number if applicable>  open-telemetry#33627

**Testing:** <Describe what testing was performed and which tests were
added.>
Added test files for the same. 

**Documentation:** <Describe the documentation added.>

---------

Signed-off-by: joeyyy09 <menteharshith@gmail.com>
Co-authored-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

fatsheep9146 fatsheep9146 approved these changes

yurishkuro yurishkuro approved these changes

MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner

pavolloffay Awaiting requested review from pavolloffay

Labels