[receiver/awsfirehose]: Fix access key validation #34847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Aneurysm9
force-pushed
the
advisory-fix-1
branch
from
e55ee20 to
27d4c5f
Compare
|
@DouglasHeriot: Can you please sign the CLA? We won't be able to merge this PR until all commit authors have signed it. |
crobert-1
approved these changes
Aug 26, 2024
codeboten
approved these changes
Aug 26, 2024
|
Done, we’ve got a Corporate CLA already signed. |
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
**Description:** The `awsfirehosereceiver` can be configured to receive CloudWatch metrics via an AWS Firehose Stream. [Firehose sets the header](https://docs.aws.amazon.com/firehose/latest/dev/httpdeliveryrequestresponse.html) `X-Amz-Firehose-Access-Key` with an arbitrary configured string. The OpenTelemetry Collector awsfirehosereceiver can optionally be configured to require this key on incoming requests. However, when this is configured it still accepts incoming requests with no key. **Link to tracking Issue:** [Advisory](GHSA-prf6-xjxh-p698) **Testing:** Tested via reproduction script provided by reporter. --------- Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> Co-authored-by: Douglas Heriot <dheriot@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The
awsfirehosereceivercan be configured to receive CloudWatch metrics via an AWS Firehose Stream. Firehose sets the headerX-Amz-Firehose-Access-Keywith an arbitrary configured string. The OpenTelemetry Collector awsfirehosereceiver can optionally be configured to require this key on incoming requests. However, when this is configured it still accepts incoming requests with no key.Link to tracking Issue: Advisory
Testing: Tested via reproduction script provided by reporter.
Fixes: GHSA-prf6-xjxh-p698