-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k8seventsreceiver & k8sobjectsreceiver: migrate to latest semconv version #35239
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading semconv is risky. Please confirm that no attributes emitted by this component change bc of this upgrade.
I confirm that risk is 0. The semconv attributes' value have been compared using go-otel-semconv-comparator resulting in 0 diffs. |
I used go-otel-semconv-comparator to check that that all constants from the older semconv version have the same value inside the newer semconv version. Thus it is safe to do this upgrade. Check the existing upgrades: #22095 |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
did my last reply answered your question ? are there any concerns on this ? @dmitryax @TylerHelmuth @hvaghani221 |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Checked were conventions are used: It appears it'd be safe to upgrade since |
Description: The version of semconv is upgraded from to v1.6.1 and v1.9.0 to v1.27.0
Link to tracking Issue: #22095
Testing: Tests passed