Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8seventsreceiver & k8sobjectsreceiver: migrate to latest semconv version #35239

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

narcis96
Copy link
Contributor

Description: The version of semconv is upgraded from to v1.6.1 and v1.9.0 to v1.27.0

Link to tracking Issue: #22095

Testing: Tests passed

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading semconv is risky. Please confirm that no attributes emitted by this component change bc of this upgrade.

@narcis96
Copy link
Contributor Author

Upgrading semconv is risky. Please confirm that no attributes emitted by this component change bc of this upgrade.

I confirm that risk is 0. The semconv attributes' value have been compared using go-otel-semconv-comparator resulting in 0 diffs.

@narcis96
Copy link
Contributor Author

narcis96 commented Oct 4, 2024

Upgrading semconv is risky. Please confirm that no attributes emitted by this component change bc of this upgrade.

@TylerHelmuth

I used go-otel-semconv-comparator to check that that all constants from the older semconv version have the same value inside the newer semconv version. Thus it is safe to do this upgrade. Check the existing upgrades: #22095

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 19, 2024
@narcis96
Copy link
Contributor Author

narcis96 commented Oct 24, 2024

did my last reply answered your question ? are there any concerns on this ? @dmitryax @TylerHelmuth @hvaghani221

@github-actions github-actions bot removed the Stale label Oct 25, 2024
Copy link
Contributor

github-actions bot commented Nov 9, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 9, 2024
@ChrsMark ChrsMark added Skip Changelog PRs that do not require a CHANGELOG.md entry and removed Stale labels Nov 15, 2024
@ChrsMark ChrsMark requested a review from a team as a code owner November 15, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
receiver/k8sevents receiver/k8sobjects Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants