[cmd/opampsupervisor] Make supervisor runnable as Windows service #35275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
atoulme,
BinaryFissionGames,
evan-bradley and
tigrannajaryan
dpaasman00
force-pushed
the
dakotapaasman/bpop-714-make-supervisor-a-compatible-windows-service
branch
from
99b24f9
to
3f57af7
Compare
pjanotti
reviewed
Sep 18, 2024
There was a problem hiding this comment.
A follow-up adding a basic test similar to https://github.com/open-telemetry/opentelemetry-collector/blob/59c083f830f3b175cd0b89ac1a1bc97c58c4c2d0/otelcol/collector_windows_service_test.go#L40 will be good.
|
This PR needs |
dpaasman00
force-pushed
the
dakotapaasman/bpop-714-make-supervisor-a-compatible-windows-service
branch
5 times, most recently
from
156a6a3
to
197fd54
Compare
dpaasman00
force-pushed
the
dakotapaasman/bpop-714-make-supervisor-a-compatible-windows-service
branch
from
67c4189
to
4eb4c19
Compare
pjanotti
reviewed
Sep 24, 2024
pjanotti
reviewed
Sep 24, 2024
cmd/opampsupervisor/supervisor/supervisor_windows_service_test.go
Outdated
Show resolved
Hide resolved
pjanotti
approved these changes
Sep 26, 2024
djaglowski
approved these changes
Oct 1, 2024
pjanotti
approved these changes
Oct 1, 2024
pjanotti
added
the
ready to merge
dpaasman00
force-pushed
the
dakotapaasman/bpop-714-make-supervisor-a-compatible-windows-service
branch
from
418ee9b
to
dada525
Compare
evan-bradley
reviewed
Oct 2, 2024
There was a problem hiding this comment.
I'm unable to review the Windows-related aspects of this PR. Thank you @BinaryFissionGames @djaglowski @pjanotti for your reviews.
I only have one comment; outside of that, once CI is green, I think we're good to merge this.
codeboten
reviewed
Oct 2, 2024
There was a problem hiding this comment.
The windows supervisor test is failing with:
Remove-Service: D:\a\_temp\9f7c6c19-fb48-4034-9af3-ba5e031c9de9.ps1:2
Line |
2 | Remove-Service opampsupervisor
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| Service 'opampsupervisor' was not found on computer '.'.
Error: Process completed with exit code 1.
Removing "ready to merge" label for now
codeboten
removed
the
ready to merge
|
@dpaasman00 the name of the artifact to be downloaded is wrong. Instead of |
dpaasman00
force-pushed
the
dakotapaasman/bpop-714-make-supervisor-a-compatible-windows-service
branch
from
ff1f631
to
5657a8e
Compare
|
@dpaasman00 Not sure whether you're up to date with main, but I think the build failure that's happening right now will be fixed if you rebase on the latest commit. |
evan-bradley
approved these changes
Oct 3, 2024
|
@dpaasman00 I think one of the other Supervisor PRs included changes that conflict with this PR. If you can resolve the conflict, I'll get this merged. |
…ailing tests" This reverts commit c219b8e.
dpaasman00
force-pushed
the
dakotapaasman/bpop-714-make-supervisor-a-compatible-windows-service
branch
from
5657a8e
to
c6a8467
Compare
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…en-telemetry#35275) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Add support for running supervisor as a Windows Service. Updates entry point to run a service handler if being ran as a Windows Service by implementing the [handler interface](https://pkg.go.dev/golang.org/x/sys/windows/svc#Handler). Also updates the Windows Commander to allocate a console if running as a service. We send a CTRL_BREAK_EVENT console event to the agent to signal a shutdown however windows services do not run with consoles. If running as service we need to allocate a console to send the signal and then free the console. **Link to tracking Issue:** <Issue number if applicable> Closes open-telemetry#34774 **Testing:** <Describe what testing was performed and which tests were added.> - Tested using a windows VM and using `sc.exe` for creating the service **Documentation:** <Describe the documentation added.>
Eromosele-SM
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2024
…en-telemetry#35275) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Add support for running supervisor as a Windows Service. Updates entry point to run a service handler if being ran as a Windows Service by implementing the [handler interface](https://pkg.go.dev/golang.org/x/sys/windows/svc#Handler). Also updates the Windows Commander to allocate a console if running as a service. We send a CTRL_BREAK_EVENT console event to the agent to signal a shutdown however windows services do not run with consoles. If running as service we need to allocate a console to send the signal and then free the console. **Link to tracking Issue:** <Issue number if applicable> Closes open-telemetry#34774 **Testing:** <Describe what testing was performed and which tests were added.> - Tested using a windows VM and using `sc.exe` for creating the service **Documentation:** <Describe the documentation added.>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add support for running supervisor as a Windows Service. Updates entry point to run a service handler if being ran as a Windows Service by implementing the handler interface.
Also updates the Windows Commander to allocate a console if running as a service. We send a CTRL_BREAK_EVENT console event to the agent to signal a shutdown however windows services do not run with consoles. If running as service we need to allocate a console to send the signal and then free the console.
Link to tracking Issue: Closes #34774
Testing:
sc.exefor creating the serviceDocumentation: