Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/redaction] fix index-out-of-bounds panic when used in logs pipeline. #35331

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

TylerHelmuth
Copy link
Member

Description:
Fixes an index issue caused by an incorrect for loop condition.

Link to tracking Issue:
closes #35316

Testing:
Updated unit test. The updated test panics without the fix

@TylerHelmuth TylerHelmuth requested review from dmitryax, mx-psi and a team as code owners September 20, 2024 18:28
@github-actions github-actions bot added the processor/redaction Redaction processor label Sep 20, 2024
@TylerHelmuth TylerHelmuth added the release:blocker The issue must be resolved before cutting the next release label Sep 20, 2024
@TylerHelmuth TylerHelmuth merged commit e93f0cc into open-telemetry:main Sep 20, 2024
162 checks passed
@TylerHelmuth TylerHelmuth deleted the redaction-fix-logs branch September 20, 2024 18:42
@github-actions github-actions bot added this to the next release milestone Sep 20, 2024
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this pull request Oct 4, 2024
… pipeline. (open-telemetry#35331)

**Description:** 
Fixes an index issue caused by an incorrect for loop condition.

**Link to tracking Issue:**
closes
open-telemetry#35316

**Testing:** <Describe what testing was performed and which tests were
added.>
Updated unit test. The updated test panics without the fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/redaction Redaction processor release:blocker The issue must be resolved before cutting the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

otlp collector keep crashing after enable redaction for log
4 participants