Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuremonitorexporter: migrate to newer semconv versions #35350

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

narcis96
Copy link
Contributor

@narcis96 narcis96 commented Sep 23, 2024

Description: The version of semconv is upgraded from v1.6.1 to newer versions

The semconv attributes' value have been compared using go-otel-semconv-comparator resulting in 0 diffs:

  • 1.7.0 version has been used if the no newer version contains all attributes used by the file (all attributes of 1.6.1 exists and have the same value inside 1.7.0)
  • 1.12.0 version has been used if the no newer version contains all attributes used by the file (all attributes of 1.6.1 exists and have the same value inside 1.12.0)
  • 1.27.0 version has been used if only if the file does not contain AttributeMessagingMessageID and AttributeMessagingKafkaMessageKey:
otel_comp

Link to tracking Issue: #22095

Testing: Tests passed

@crobert-1 crobert-1 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 24, 2024
@dmitryax dmitryax merged commit 2ba5447 into open-telemetry:main Sep 24, 2024
163 of 164 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 24, 2024
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this pull request Oct 4, 2024
…ry#35350)

Description: The version of semconv is upgraded from v1.6.1 to newer
versions

The semconv attributes' value have been compared using
[go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator)
resulting in 0 diffs:
- 1.7.0 version has been used if the no newer version contains all
attributes used by the file (all attributes of 1.6.1 exists and have the
same value inside 1.7.0)
- 1.12.0 version has been used if the no newer version contains all
attributes used by the file (all attributes of 1.6.1 exists and have the
same value inside 1.12.0)
- 1.27.0 version has been used if only if the file does _not_ contain
_AttributeMessagingMessageID_ and _AttributeMessagingKafkaMessageKey_:

<img width="798" alt="otel_comp"
src="https://github.com/user-attachments/assets/5e9befc7-80f9-4758-a357-0dec82373a11">

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/azuremonitor Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants