[pkg/ottl] Add ToKeyValueString Converter #35409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuiperda
requested review from
TylerHelmuth,
bogdandrutu,
evan-bradley and
a team
as code owners
djaglowski
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
I like the round trip tests. This looks good to me. cc @TylerHelmuth
kuiperda
force-pushed
the
feat/marshalkv
branch
from
f2e9f4a
to
21b464c
Compare
|
@TylerHelmuth Thanks for the feedback, I believe I've addressed everything. |
kuiperda
changed the title
kuiperda
force-pushed
the
feat/marshalkv
branch
from
21b464c
to
2aab285
Compare
|
@TylerHelmuth I've addressed the feedback from yesterday. |
TylerHelmuth
approved these changes
Oct 1, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Implements ToKeyValueString OTTL Converter. **Link to tracking Issue:** open-telemetry#35334 **Testing:** Added unit tests and e2e **Documentation:** Added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implements ToKeyValueString OTTL Converter.
Link to tracking Issue: #35334
Testing: Added unit tests and e2e
Documentation: Added