-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore][exporter/elasticsearch] Rename OTel mode dynamic template summary_metrics to summary #35424
[chore][exporter/elasticsearch] Rename OTel mode dynamic template summary_metrics to summary #35424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No changelog as this should not concern end users. This is a coordinated change between in-development Elasticsearch otel-data plugin and in-development elasticsearchexporter OTel mapping mode.
Does this mean users should be using a specific version of the Elasticsearch exporter with a specific version of Elasticsearch? What if a user runs the collector v0.109.0 (without this change) with a future version of Elasticsearch, e.g. v8.16? What if a user runs the collector e.g. v0.111.0 (with this change) with a previous version of Elasticsearch like v8.15.x?
ES otel-data plugin is not released yet. It is under active development targeting 8.16. We should only care about the compatibility once the ES plugin released in 8.16. Also note that this change only affects OTel mapping mode. i.e.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @carsonip for the explanation, makes sense to me.
…mary_metrics to summary (open-telemetry#35424) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Renaming OTel mode dynamic template summary_metrics to summary to align with Elasticsearch otel-data change elastic/elasticsearch#113409 **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> No changelog as this should not concern end users. This is a coordinated change between in-development Elasticsearch otel-data plugin and in-development elasticsearchexporter OTel mapping mode.
Description:
Renaming OTel mode dynamic template summary_metrics to summary to align with Elasticsearch otel-data change elastic/elasticsearch#113409
Link to tracking Issue:
Testing:
Documentation:
No changelog as this should not concern end users. This is a coordinated change between in-development Elasticsearch otel-data plugin and in-development elasticsearchexporter OTel mapping mode.