[processor/metricsgeneration] Fix panic when using a sum metric for calculations #35428
+2,712
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The metrics generation processor would previously hit a panic when the calculation rule was operating on a
sum
metric, instead of agauge
. The component proposal, initial implementation, nor the README state that it's a requirement for the metric to be agauge
, nor do I think this requirement makes sense.I've updated the logic to account for sum metrics being used and added a test.
Testing:
Added a test for this situation, the test panics before the change and passes after.