[exporter/elasticsearch] Implement elasticsearch.mapping.hints attribute handling for data points in OTel mapping mode #35479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahsivjar
reviewed
Sep 30, 2024
carsonip
changed the title
carsonip
commented
Sep 30, 2024
| @@ -7,15 +7,18 @@ change_type: enhancement | |||
| component: elasticsearchexporter | |||
|
|
|||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | |||
| note: Emit _doc_count for metric documents in OTel mode when data point attribute _doc_count is true | |||
There was a problem hiding this comment.
[to reviewer] Removing changelog for previous doc count PR as this PR supersedes it. It does not make sense for the doc count PR changelog to be in the release notes of the next version if it is not relevant.
mwear
approved these changes
Sep 30, 2024
|
@mwear Thanks for the review. I've fixed the CI check. But would love eyes from @lahsivjar and @felixbarny before merging it. |
felixbarny
approved these changes
Oct 1, 2024
andrzej-stencel
approved these changes
Oct 1, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…ute handling for data points in OTel mapping mode (open-telemetry#35479) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Supersedes open-telemetry#35348 elasticsearch.mapping.hints takes a slice of strings. `_doc_count` enables emitting `_doc_count` for the document. `aggregate_metric_double` causes histogram or exponential histogram to be emitted as aggregate_metric_double. **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Supersedes #35348
elasticsearch.mapping.hints takes a slice of strings.
_doc_countenables emitting_doc_countfor the document.aggregate_metric_doublecauses histogram or exponential histogram to be emitted as aggregate_metric_double.Link to tracking Issue:
Testing:
Documentation: